Ticket #8023 (review_failed Bug)

Opened 4 years ago

Last modified 4 years ago

[IE] Toolbar is selectable

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone:
Component: UI : Toolbar Version: 3.0
Keywords: IE Cc:

Description

Start mouse drag from the left of the very first button (Source) in the toolbox area (with grey background), dragging over the toolbar icons, it's still possible to make text selection.

Attachments

8023.patch (1.2 KB) - added by garry.yao 4 years ago.

Change History

comment:1 Changed 4 years ago by garry.yao

Opera is also affected by the same issue.

Changed 4 years ago by garry.yao

comment:2 Changed 4 years ago by garry.yao

  • Status changed from new to review
  • Owner set to garry.yao

We could safely avoid recursive unselectable attribute on IE explained here.

comment:3 Changed 4 years ago by fredck

  • Status changed from review to review_failed

The patch doesn't make any difference if you start dragging from the page space above the editor. Additionally, the change makes it possible to drag the unselectable stuff, which is one of the most important features of the current implementation.

There is no need to work on this right now. Let's wait for an outsider to report issues related to this first.

comment:4 Changed 4 years ago by garry.yao

The patch doesn't make any difference if you start dragging from the page space above the editor.

No, unselectable only takes care of the selection start within the target element, it's not privileged for deciding whether it will get included in outer selection, which is not part of this ticket.

Additionally, the change makes it possible to drag the unselectable stuff

I cannot confirm it, can you provide more details?

There's no hurry stated on this ticket, it's kind of optimization over the old code.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy