Ticket #8055 (closed Bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Allow captions that include entities to be edited through the dialog

Reported by: Saare Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.6.1
Component: Core : Tables Version: 3.6.1
Keywords: Cc:

Description

FUP of #6663.
It is now impossible to edit html in table captions thorugh the dialog, but we should support entities in there, e.g. non-breaking spaces.

Attachments

8055.patch (863 bytes) - added by garry.yao 3 years ago.
8055_2.patch (1.8 KB) - added by garry.yao 3 years ago.
8055_3.patch (1.6 KB) - added by garry.yao 3 years ago.

Change History

Changed 3 years ago by garry.yao

comment:1 Changed 3 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to review
  • Component changed from General to Core : Tables

comment:2 Changed 3 years ago by Saare

  • Status changed from review to review_failed

Putting spaces inside the dialog field inserts plain spaces instead of the expected non-breakable spaces.

Changed 3 years ago by garry.yao

comment:3 Changed 3 years ago by garry.yao

  • Status changed from review_failed to review

Second patch takes care of this, but seems to work in IE only, anyway we can proceed with this which is considered as the correct way and leave other hacks later.

comment:4 Changed 3 years ago by Saare

  • Status changed from review to review_failed

Actually it doesn't seem to work in any browser, giving a JS error instead.

Changed 3 years ago by garry.yao

comment:5 Changed 3 years ago by garry.yao

  • Status changed from review_failed to review

comment:6 Changed 3 years ago by Saare

  • Status changed from review to review_failed

Doesn't work when multiple spaces are in the initial caption text (when creating a table, not editing it).

comment:7 Changed 3 years ago by garry.yao

  • Status changed from review_failed to review

#8075 is opened for the white-spaces issue, please continue to review 8055.patch.

Last edited 3 years ago by garry.yao (previous) (diff)

comment:8 Changed 3 years ago by Saare

  • Status changed from review to review_passed

R+ for 8055.patch.

comment:9 Changed 3 years ago by garry.yao

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [7057].

comment:10 Changed 3 years ago by wwalc

Since it was possible to edit such captions in 3.6, I have removed the changelog entry with [7058].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy