Opened 5 years ago

Closed 5 years ago

#8087 closed Bug (fixed)

RTL: Indenting list adds extra dir attributes to list items.

Reported by: wwalc Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.6.2
Component: Core : Lists Version: 3.6.1
Keywords: Cc: satya_minnekanti@…

Description

Caused by [6928].

  1. Start with
    <ul dir="rtl">
    	<li>
    		one</li>
    	<li>
    		two</li>
    	<li>
    		three</li>
    	<li>
    		four</li>
    </ul>
    
  2. Select two list items in the middle ("two" and "three").
  3. Press "Increase Indent"
  4. Result:
    <ul dir="rtl">
    	<li>
    		one
    		<ul>
    			<li dir="rtl">
    				two</li>
    			<li dir="rtl">
    				three</li>
    		</ul>
    	</li>
    	<li>
    		four</li>
    </ul>
    

Previously the result was:

<ul dir="rtl">
	<li>
		one
		<ul>
			<li>
				two</li>
			<li>
				three</li>
		</ul>
	</li>
	<li>
		four</li>
</ul>

Attachments (3)

8087.patch (2.3 KB) - added by garry.yao 5 years ago.
8087_2.patch (2.9 KB) - added by garry.yao 5 years ago.
8087_3.patch (2.7 KB) - added by garry.yao 5 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 5 years ago by j.swiderski

  • Status changed from new to confirmed

comment:2 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from confirmed to review

At least #6861, #8042, #8053 must be re-checked.

Changed 5 years ago by garry.yao

comment:4 Changed 5 years ago by garry.yao

comment:5 Changed 5 years ago by satya

  • Cc satya_minnekanti@… added

comment:6 Changed 5 years ago by wwalc

  • Milestone changed from CKEditor 3.6.1 to CKEditor 3.6.2

Unless anything more serious will be found while working with lists, we can correct it in the next release.

The text direction is correct, so let's work on it straight after the release to keep the resulting HTML code as clean as possible.

Changed 5 years ago by garry.yao

comment:7 Changed 5 years ago by garry.yao

Looks like wiser to just keep element::getDirection simple.

comment:8 Changed 5 years ago by fredck

  • Keywords NeedsTest added

comment:9 Changed 5 years ago by garry.yao

Last edited 5 years ago by fredck (previous) (diff)

Changed 5 years ago by garry.yao

comment:10 Changed 5 years ago by garry.yao

  • Keywords NeedsTest removed

comment:11 Changed 5 years ago by fredck

  • Status changed from review to review_passed

comment:12 Changed 5 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [7219].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy