WebKit: Cut/Copy don't go on "enabled" state

[Frederico Caldeira Knabben]

Original message from our contact form, Ticket REF : 3815-QDFX-1500.

---

I found that 'cut' and 'copy' icons do not go to enabled state after you select text in editor (chrome v. 14.0.835.202 m windows). After exploring this I found that there is a problem with queryCommandEnabled function in clipboard plugin, so I propose a solution to you.

function stateFromNamedCommand( command, editor )
{
// IE Bug: queryCommandEnabled('paste') fires also
'beforepaste(copy/cut)',
// guard to distinguish from the ordinary sources( either
// keyboard paste or execCommand ) (#4874).
CKEDITOR.env.ie && ( depressBeforeEvent = 1 );

var retval = CKEDITOR.TRISTATE_OFF;
try {retval = editor.document.$.queryCommandEnabled( command ) ||
CKEDITOR.env.webkit && editor.getSelection().getRanges()[0].startOffset !=
editor.getSelection().getRanges()[0].endOffset ? CKEDITOR.TRISTATE_OFF :
CKEDITOR.TRISTATE_DISABLED;}catch( er ){}

depressBeforeEvent = 0;
return retval;
}

[Jakub Ś]

Reproducible from CKEditor 3.5.1 rev [6311]

[Piotrek Koszuliński]

That bug is visible from rev [6311] because in this revision states of buttons had been bound to what stateFromNamedComand is returning. This function was buggy even before that.

[David]

Are there any plans to integrate the proposed patch?

[Adam]

I would also like to see a solution for this issue.

[Piotrek Koszuliński]

This issue is already fixed in dev version of next major release (inaccessible for you).

I ported correct patch to version 3.6.3 - you can apply it if you want, or wait for new major or bugfixing release.

[Adam]

@Reinmar, that's awesome. Thank you for this!

[Piotrek Koszuliński]

Fixed with [7504].

[Jakub Ś]

#9143 - there is still a problem when you select content with cursor placed underneath this content.