Ticket #8812 (closed Bug: fixed)

Opened 2 years ago

Last modified 2 years ago

IE9: HTML comment blocks Enter Key

Reported by: j.swiderski Owned by: fredck
Priority: Normal Milestone: CKEditor 3.6.3
Component: Core : Selection Version: 3.0
Keywords: IE9 Cc:

Description

  1. open the http://ckeditor.com/demo/ in IE9
  2. press source button to switch to source mode.
  3. remove all default contents.
  4. input this line. test <!-- -->
  5. press source button and switch to WYSIWYG mode.
  6. Click in editor (doesn't matter where) and press Enter key.

Result: Enter key does not work.

Attachments

8812.patch (793 bytes) - added by fredck 2 years ago.
8812_2.patch (1.3 KB) - added by fredck 2 years ago.
8812_3.patch (2.3 KB) - added by fredck 2 years ago.

Change History

comment:1 Changed 2 years ago by j.swiderski

  • Status changed from new to confirmed

Changed 2 years ago by fredck

comment:2 Changed 2 years ago by fredck

  • Owner set to fredck
  • Status changed from confirmed to review

comment:3 Changed 2 years ago by garry.yao

  • Status changed from review to review_failed

Patch fails the following tc:

http://ckeditor.t/tt/8812/1.html

Changed 2 years ago by fredck

comment:4 Changed 2 years ago by fredck

  • Status changed from review_failed to review
  • Component changed from General to Core : Selection

The previous patch was working on a sightly different tc than the provided one. Because of this I've updated the test, adding both tcs there.

The new patch fixes instead the root of the problem, which is related to the IE Range to CKEDITOR.dom.range transformation. This is a more global fix, which can help us avoiding unknown issues all around the code.

comment:5 Changed 2 years ago by fredck

The provide patch fixes #8569 as well.

comment:6 Changed 2 years ago by fredck

  • Milestone set to CKEditor 3.6.3

comment:7 Changed 2 years ago by garry.yao

  • Status changed from review to review_failed

Patch fails one tc that is added to the ticket test, pls check, basically the patch needs to change also the "else" block in the range mapping hunk.

Changed 2 years ago by fredck

comment:8 Changed 2 years ago by fredck

  • Status changed from review_failed to review

comment:9 Changed 2 years ago by garry.yao

  • Status changed from review to review_passed

comment:10 Changed 2 years ago by fredck

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [7415].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy