Ticket #8832 (review Bug)

Opened 2 years ago

Last modified 2 years ago

Stylesheet parser error if file not on cache

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone:
Component: General Version: 3.6
Keywords: HasPatch Cc: joel.peltonen@…

Description

#7784 didn't fix the problem correctly

Reproduction steps:

  1. Clear the cache
  2. Open the console
  3. Load http://nightly.ckeditor.com/latest/ckeditor/_samples/stylesheetparser.html
  4. See the error as reported originally.

Proposed solution:

Revert [6867] and use http://dev.ckeditor.com/attachment/ticket/7784/7784_2.patch as it wasn't rejected because it failed but instead based on coding style. Or rewrite it anyway that you like and test that now it's correctly fixed.

Attachments

8832.patch (2.3 KB) - added by alfonsoml 2 years ago.
Proposed patch

Change History

comment:1 Changed 2 years ago by grek

in my source of stylesheetparser/plugin.js i dont see code like 7784_2.patch i have this code http://pastebin.com/ycemwBqU , please paste all fixed code with patch 7784_2.patch not only change.

example in patch in code we see "editor.getStylesSet( function( stylesDefinitions ) " in current source code i see obj.getStylesSet = CKEDITOR.tools.override( obj.getStylesSet, function( org )

here http://dev.ckeditor.com/browser/CKEditor/branches/versions/3.6.x/_source/plugins/stylesheetparser/plugin.js?rev=6867 i see version witch i have so how aply patch to this version - patch is for other code ?

so i dont know to witch version is patch like i write please paste to some place working version of this plugin , thanks

Last edited 2 years ago by grek (previous) (diff)

comment:2 Changed 2 years ago by grek

So anyone know to resolve it ? i can put settimeout if it can help but where ?

comment:3 Changed 2 years ago by grek

help please

comment:4 Changed 2 years ago by j.swiderski

  • Status changed from new to confirmed

Reproducible from CKEditor 3.6 rev [6904]

Changed 2 years ago by alfonsoml

Proposed patch

comment:5 Changed 2 years ago by alfonsoml

  • Owner set to alfonsoml
  • Status changed from confirmed to review

The patch fixes this problem as well as #7810

comment:6 Changed 2 years ago by req

  • Cc joel.peltonen@… added
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy