Ticket #8857 (closed Bug: fixed)

Opened 3 years ago

Last modified 2 years ago

wrong variable "name" used instead of "tagName"

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: CKEditor 3.6.4
Component: Core : Parser Version:
Keywords: Cc:

Description

In the core/htmlparser/element.js file, this block

	var tagName = attributes[ 'data-cke-real-element-type' ] || name || '';

	// Reveal the real semantic of our internal custom tag name (#6639).
	var internalTag = tagName.match( /^cke:(.*)/ );
  	internalTag && ( tagName = internalTag[ 1 ] );

	var dtd			= CKEDITOR.dtd,
		isBlockLike	= !!( dtd.$nonBodyContent[ tagName ]
				|| dtd.$block[ tagName ]
				|| dtd.$listItem[ tagName ]
				|| dtd.$tableContent[ tagName ]
				|| dtd.$nonEditable[ tagName ]
				|| tagName == 'br' ),
		isEmpty = !!dtd.$empty[ name ];

	this.isEmpty	= isEmpty;
	this.isUnknown	= !dtd[ name ];

I think that the "name" in lines 50 and 53 should be tagName as all the rest of uses, but instead of applying it as a microchange I would prefer if someone could confirm it.

Attachments

8857.patch (557 bytes) - added by alfonsoml 3 years ago.
Proposed patch

Change History

Changed 3 years ago by alfonsoml

Proposed patch

comment:1 Changed 3 years ago by alfonsoml

  • Status changed from new to review
  • Owner set to alfonsoml

comment:2 Changed 2 years ago by garry.yao

  • Status changed from review to review_passed
  • Milestone set to CKEditor 3.6.4

comment:3 Changed 2 years ago by garry.yao

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [7542].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy