Ticket #898 (closed New Feature: fixed)

Opened 7 years ago

Last modified 6 years ago

Add EditorAreaCSS to image preview

Reported by: redtopia@… Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6.1
Component: General Version:
Keywords: SF Review+ Cc:

Description

It would be a nice improvement for the image preview pane to view the image in the context of the current editor area CSS file. To do this, I've added this code to the <head> of the fck_image_preview.html file: (inside the exisiting <script>)

// Sets the editor area CSS
if (window.parent.FCKConfig.EditorAreaCSS.length > 0)
document.write( '<link href="' +
window.parent.FCKConfig.EditorAreaCSS + '"
type="text/css" rel="stylesheet">' ) ;

Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1496671&group_id=75348&atid=543656

Attachments

898.patch (1.6 KB) - added by alfonsoml 6 years ago.
Proposed SVN patch

Change History

comment:1 Changed 7 years ago by martinkou

  • Reporter changed from martinkou to redtopia@…

comment:2 Changed 6 years ago by w.olchawa

  • Keywords HasPatch added

comment:3 Changed 6 years ago by alfonsoml

  • Owner set to alfonsoml
  • Status changed from new to assigned

Changed 6 years ago by alfonsoml

Proposed SVN patch

comment:4 Changed 6 years ago by alfonsoml

  • Keywords Review? added; HasPatch removed

This should be enough to be able to see the images with the classes applied to them.

comment:5 Changed 6 years ago by fredck

  • Keywords Review+ added; Review? removed
  • Milestone set to FCKeditor 2.6.1

I don't want to Review- it just because of this, but please remove the indentation from lines 38 and 39 before committing.

comment:6 Changed 6 years ago by alfonsoml

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [2023]

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy