#8995 closed Bug (fixed)
Link gets destroyed in bbcode when you modify it
| Reported by: | Jakub Ś | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.6.5 |
| Component: | General | Version: | 3.6 |
| Keywords: | Cc: |
Description
To reproduce:
- Open bbcode sample and clear all contents
- Insert link
http://google.com?test=1&abc=xtusing link dialog - Now realize that parameter
abcshould have valuetxtnotxt:). Try to correct it. - Switch to source
Result:
[url=http://google.com?test=1&abc=xt]http://google.com?test=1&abc=txt[/url]
Ampersand is escaped and URL got doubled.
Each time you switch to source and back new amp; is added:
[url=http://google.com?test=1&abc=xt]http://google.com?test=1&abc=txt[/url]
Reproducible in all browsers from CKEditor 3.6.
Attachments (1)
Change History (8)
comment:1 Changed 13 years ago by
| Status: | new → confirmed |
|---|
Changed 12 years ago by
| Attachment: | 8995.patch added |
|---|
comment:3 Changed 12 years ago by
| Milestone: | → CKEditor 3.6.5 |
|---|---|
| Owner: | set to Garry Yao |
| Status: | confirmed → review |
comment:4 Changed 12 years ago by
While the patch doest not prevent from escaping HTML (which is wrong) on output, it avoid HTML-escaping BBCode from source, which will break a second load for the above case.
comment:5 Changed 12 years ago by
| Status: | review → review_passed |
|---|
comment:6 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [7598].
comment:7 Changed 12 years ago by
[7598] caused a regression identified by test:
http://ckeditor.t/dt/plugins/bbcode/plugin.html
Re-fixing with [7628].
Note: See
TracTickets for help on using
tickets.
Here is a screencast showing that the same thing happens when you modify initial content: http://screenr.com/5tX8
It was reported in #8751 but I'm leaving this one open as it is addressing the problem more accurately.