Ticket #9059 (closed Bug: invalid)
A better way to protect source in htmldataprocessor
| Reported by: | yiminghe | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | General | Version: | 3.0 |
| Keywords: | Cc: |
Description
Current way of using regexp to protectSource/unprotectSource/protectRealComments/unprotectRealComments is not so good and hard to maintain, it's better using html parser to achieve the same objective.
Please review my code attachment.
Attachments
Change History
Changed 11 months ago by yiminghe
- Attachment protect_source.patch added
comment:1 Changed 11 months ago by garry.yao
- Version changed from 3.6.4 (SVN - trunk) to 3.0
Tks for contribution, the patch produces neater code, but what are subjected to be protected, includes not only HTML <script> content, but other non-HTML data as well, e.g. other embedded language, thus the proposed patch breaks protectedSource configuration.
comment:2 Changed 11 months ago by j.swiderski
- Keywords htmldataprocessor removed
- Status changed from new to closed
- Resolution set to invalid
Thanks for the review @garry.yao. If this patch is breaking protectedSource I have to close this ticket as invalid. Sorry @yiminghe and thank you for contribution.
Note: See
TracTickets for help on using
tickets.

code patch for htmldataprocessor