Opened 12 years ago

Closed 10 years ago

#9075 closed Bug (duplicate)

Code error in verticalSplitCell function

Reported by: tengshengbo Owned by:
Priority: Normal Milestone:
Component: Core : Tables Version: 3.0
Keywords: Cc:

Description

There is a bug in verticalSplitCell function, tabletools plugin. Current code: function verticalSplitCell ( selection, isDetect )

The destination row is empty, append at will.

if ( !candidateCell ){

newCellTr.append( newCell, true);

}

The destination row may not be empty when candidateCell is null, and the argument "true" should not be used.

Right code:

if ( !candidateCell ){

newCellTr.append( newCell );

}

Attachments (1)

9075.patch (431 bytes) - added by Jakub Ś 12 years ago.
patch proposed by @tengshengbo

Download all attachments as: .zip

Change History (5)

comment:1 Changed 12 years ago by Jakub Ś

Status: newpending

Could we ask you for a TC in which this error occurs? Any chance for a step by step scenario or reduced test case file?

comment:2 Changed 12 years ago by tengshengbo

Test case:

  • insert a 4 * 4 table,
  • v-split the left-top cell,
  • h-split the right-down cell,
  • v-split the right-top cell.
Last edited 12 years ago by Jakub Ś (previous) (diff)

comment:3 Changed 12 years ago by Jakub Ś

Status: pendingconfirmed
Version: 3.6.33.0

Changed 12 years ago by Jakub Ś

Attachment: 9075.patch added

patch proposed by @tengshengbo

comment:4 Changed 10 years ago by Piotrek Koszuliński

Resolution: duplicate
Status: confirmedclosed

DUP of #11438.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy