Ticket #9075 (closed Bug: duplicate)

Opened 22 months ago

Last modified 2 months ago

Code error in verticalSplitCell function

Reported by: tengshengbo Owned by:
Priority: Normal Milestone:
Component: Core : Tables Version: 3.0
Keywords: Cc:

Description

There is a bug in verticalSplitCell function, tabletools plugin. Current code: function verticalSplitCell ( selection, isDetect )

The destination row is empty, append at will.

if ( !candidateCell ){

newCellTr.append( newCell, true);

}

The destination row may not be empty when candidateCell is null, and the argument "true" should not be used.

Right code:

if ( !candidateCell ){

newCellTr.append( newCell );

}

Attachments

9075.patch (431 bytes) - added by j.swiderski 22 months ago.
patch proposed by @tengshengbo

Change History

comment:1 Changed 22 months ago by j.swiderski

  • Status changed from new to pending

Could we ask you for a TC in which this error occurs? Any chance for a step by step scenario or reduced test case file?

comment:2 Changed 22 months ago by tengshengbo

Test case:

  • insert a 4 * 4 table,
  • v-split the left-top cell,
  • h-split the right-down cell,
  • v-split the right-top cell.
Last edited 22 months ago by j.swiderski (previous) (diff)

comment:3 Changed 22 months ago by j.swiderski

  • Status changed from pending to confirmed
  • Version changed from 3.6.3 to 3.0

Changed 22 months ago by j.swiderski

patch proposed by @tengshengbo

comment:4 Changed 2 months ago by Reinmar

  • Status changed from confirmed to closed
  • Resolution set to duplicate

DUP of #11438.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy