Horizontal scroll on Webkits when floating toolbar doesn't fit in viewport

[Piotrek Koszuliński]

On FF toolbar is resized to fit. In fact this isn't perfect solution too, because toolbar layout is changed (and therefore is different than for editor in left/right column), what may be confusing for users and doesn't look very well. I think that it should be aligned to right/left side of the viewport.

[Frederico Caldeira Knabben]

Correct. It should touch the right side of the viewport, but not cross it.

[Olek Nowodziński]

Proposed the ​t/9769 fix for all browsers that keeps the floating space visible for as long as possible when scaling-down the window by attaching it to the opposite side of the viewport.

I also revisited and commented existing code since tapeworms like this:

var newLeft = alignSide == 'left' ? ( editorRect.left > 0 ? editorRect.left : 0 ) : ( editorRect.right < viewRect.width ? viewRect.width - editorRect.right : 0 );

are nothing like a extendable and understandable code.

[Piotrek Koszuliński]

Toolbar opens outside the left border of the viewport. See screenshot.

Second issue - there's a difference between Chrome and FF (and probably other browsers). When viewport.width < toolbar.width on FF toolbar is resized, but on Chrome toolbar stays wide and is displayed outside right border (but it's reachable). We have to make a decision how that should work. Both options have pros and cons...

[Frederico Caldeira Knabben]

Replying to Reinmar:

Toolbar opens outside the left border of the viewport.

I agree... it should not cross the left boundary.

Second issue - there's a difference between Chrome and FF (and probably other browsers). When viewport.width < toolbar.width on FF toolbar is resized, but on Chrome toolbar stays wide and is displayed outside right border (but it's reachable). We have to make a decision how that should work. Both options have pros and cons...

That's another issue which should not block this ticket. For now, KISS and let's get focused on the position.

[Olek Nowodziński]

• Pushed a ​commit that makes sure that the floating space never crosses the left edge of the viewport.
• Pushed ​another commit that forces panel positioning since it's really buggy while scrolling the entire webpage (see video attachment:floatingspacePinModeXpos.ogv​​ on master).

[Olek Nowodziński]

Extracted floating space resize issue to separate ticket #9832.

[Olek Nowodziński]

Rebased branch to the latest master.

[Olek Nowodziński]

Fixed with ​git:120ff5e4002b9b