#9875 closed Bug (fixed)
Table dialog doesn't populate width correctly
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0.1 |
| Component: | Core : Tables | Version: | 4.0.1 |
| Keywords: | Cc: |
Description (last modified by )
- Open any sample (on dev version).
- Open table dialog.
- Reset width (default is 500).
- Insert table.
- Open table dialog to edit inserted table.
- Width is set
'500'again.
Now repeat these steps with extraPlugins = 'dialogadvtab'. On step 6. width is correctly set to empty value.
Change History (8)
comment:1 Changed 11 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 11 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | new → review |
comment:4 Changed 11 years ago by
comment:5 Changed 11 years ago by
Let's keep this ticket, because I noticed it during running tests for 4.0.1.
One of table test for release version was failing, but on dev it's green. This happens because in full preset dialogadvtab is loaded and it somehow fixes incorrect dialog tab behaviour. I think that it overwrites incorrectly loaded default value with correct one, but I'm not sure when that happens. Anyway - patch propsed in t/9875 seems to fix this. For unclear reason empty value wasn't loaded so default was used. This was repeated in tests, so I had to fix them too.
comment:6 Changed 11 years ago by
It feels fine for me, so R+...
On the other hand, I have a creepy feeling since this worked fine in 4.0 and we really don't know why it was broken.
comment:7 Changed 11 years ago by
| Status: | review → review_passed |
|---|
Nothing worked fine in 4.0. See reported tickets which I linked above.
It only worked fine when dialogadvtab plugin was loaded.
PS. You're so indecisive that I'm R+ing this by my own :>.
comment:8 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with git:097a0a8.
Pushed t/9875 @dev&tests.