Ticket #2467: 2467.patch

_whatsnew.html

@@ -43 +43 @@
         <p>
                 Fixed Bugs:</p>
         <ul>
-                <li></li>
+                <li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/2467">#2467</a>] Fixed JavaScript
+                        error with the fit window command in source mode.</li>
         </ul>
         <p>
                 <a href="_whatsnew_history.html">See previous versions history</a></p>

editor/_source/commandclasses/fckfitwindow.js

@@ -38 +38 @@
         var eParent ;
 
         // Save the current selection and scroll position.
-        var oRange = new FCKDomRange( FCK.EditorWindow ) ;
-        oRange.MoveToSelection() ;
-        var oEditorScrollPos = FCKTools.GetScrollPosition( FCK.EditorWindow ) ;
+        var oRange, oEditorScrollPos ;
+        if ( FCK.EditMode == FCK_EDITMODE_WYSIWYG )
+        {
+                oRange = new FCKDomRange( FCK.EditorWindow ) ;
+                oRange.MoveToSelection() ;
+                oEditorScrollPos = FCKTools.GetScrollPosition( FCK.EditorWindow ) ;
+        }
+        else
+        {
+                var eTextarea = FCK.EditingArea.Textarea ;
+                oRange = FCKBrowserInfo.IsIE ? null : [ eTextarea.selectionStart, eTextarea.selectionEnd ] ;
+                oEditorScrollPos = [ eTextarea.scrollLeft, eTextarea.scrollTop ] ;
+        }
 
         // No original style properties known? Go fullscreen.
         if ( !this.IsMaximized )
@@ -167 +177 @@
         FCK.Focus() ;
 
         // Restore the selection and scroll position of inside the document.
-        oRange.Select() ;
-        FCK.EditorWindow.scrollTo( oEditorScrollPos.X, oEditorScrollPos.Y ) ;
+        if ( FCK.EditMode == FCK_EDITMODE_WYSIWYG )
+        {
+                oRange.Select() ;
+                FCK.EditorWindow.scrollTo( oEditorScrollPos.X, oEditorScrollPos.Y ) ;
+        }
+        else
+        {
+                if ( !FCKBrowserInfo.IsIE )
+                {
+                        eTextarea.selectionStart = oRange[0] ;
+                        eTextarea.selectionEnd = oRange[1] ;
+                }
+                eTextarea.scrollLeft = oEditorScrollPos[0] ;
+                eTextarea.scrollTop = oEditorScrollPos[1] ;
+        }
 }
 
 FCKFitWindow.prototype.GetState = function()