Ticket #4677: 4677_2.patch

_source/core/dom/element.js

@@ -739 +739 @@
                  */
                 isVisible : function()
                 {
-                        return this.$.offsetWidth && ( this.$.style.visibility != 'hidden' );
+                        {
+                                var elementWindow = this.getWindow(),
+                                        elementFrame,
+                                        isVisible = !!this.$.offsetHeight && this.getComputedStyle( 'visibility' ) != 'hidden';
+
+                                // Webkit and Opera report non-zero offsetHeight despite that
+                                // element is inside an invisible iframe. (#4542)
+                                if( isVisible && ( CKEDITOR.env.webkit || CKEDITOR.env.opera )
+                                        && !elementWindow.equals( CKEDITOR.document.getWindow() )
+                                        && ( elementFrame = elementWindow.$.frameElement ) )
+                                        isVisible = new CKEDITOR.dom.element( elementFrame ).isVisible();
+
+                                return isVisible;
+                        }
                 },
 
                 /**

_source/plugins/dialog/plugin.js

@@ -464 +464 @@
                 this.focusIndex = index;
                 this.isFocusable = function()
                 {
-                        return true;
+                        return !( element.getAttribute( 'disabled' ) || !element.isVisible() )
                 };
                 this.focus = function()
                 {
@@ -2460 +2460 @@
                  */
                 isVisible : function()
                 {
-                        var element = this.getInputElement(),
-                                elementWindow = element.getWindow(),
-                                elementFrame,
-                                isVisible = !!element.$.offsetHeight;
-
-                        // Webkit and Opera report non-zero offsetHeight despite that
-                        // element is inside an invisible iframe. (#4542)
-                        if( isVisible && ( CKEDITOR.env.webkit || CKEDITOR.env.opera )
-                                && !elementWindow.equals( CKEDITOR.document.getWindow() )
-                                && ( elementFrame = elementWindow.$.frameElement ) )
-                                isVisible = !!elementFrame.offsetHeight;
-
-                        return isVisible;
+                        return this.getInputElement().isVisible();
                 },
 
                 /**

_source/plugins/dialogui/plugin.js

@@ -838 +838 @@
 
                                 isVisible : function()
                                 {
-                                        return !!this.getElement().$.firstChild.offsetHeight;
+                                        return this.getElement().getFirst().isVisible();
                                 },
 
                                 isEnabled : function()