Ticket #7728: 7728.patch

_source/plugins/link/plugin.js

@@ -68 +68 @@
 
                 editor.on( 'doubleclick', function( evt )
                         {
-                                var element = CKEDITOR.plugins.link.getSelectedLink( editor ) || evt.data.element;
+                                var element;
+                                var openDialog;
 
-                                if ( !element.isReadOnly() )
-                                {
-                                        if ( element.is( 'a' ) )
-                                                evt.data.dialog =  ( element.getAttribute( 'name' ) && !element.getAttribute( 'href' ) ) ? 'anchor' : 'link';
-                                        else if ( element.is( 'img' ) && element.data( 'cke-real-element-type' ) == 'anchor' )
-                                                evt.data.dialog = 'anchor';
-                                }
+                                // Fake anchor image or empty anchor.
+                                if ( ( element = evt.data.element )
+                                                && ( element.is( 'img' ) && element.data( 'cke-real-element-type' ) == 'anchor'
+                                                        || element.is( 'a' ) && !element.getChildCount() ) )
+                                {
+                                                openDialog = 1;
+                                }
+                                // Link text is fully selected only (#7728).
+                                else
+                                {
+                                        var range = editor.getSelection().getRanges()[ 0 ];
+                                        range.shrink( CKEDITOR.SHRINK_TEXT );
+                                        element = range.getCommonAncestor().getAscendant( 'a', 1 );
+                                        if ( element && range.checkBoundaryOfElement( element, CKEDITOR.START )
+                                                        && range.checkBoundaryOfElement( element, CKEDITOR.END ) )
+                                        {
+                                                openDialog = 1;
+                                        }
+                                }
+
+                                if ( openDialog )
+                                {
+                                        if ( !element.isReadOnly() )
+                                        {
+                                                if ( element.is( 'a' ) )
+                                                {
+                                                        evt.data.dialog = ( element.getAttribute( 'name' ) && ( !element.getAttribute( 'href' ) || !element.getChildCount() ) ) ? 'anchor' : 'link';
+                                                        editor.getSelection().selectElement( element );
+                                                }
+                                                else if ( element.is( 'img' ) && element.data( 'cke-real-element-type' ) == 'anchor' )
+                                                        evt.data.dialog = 'anchor';
+                                        }
+                                }
+
                         });
 
                 // If the "menu" plugin is loaded, register the menu items.