Changes between Initial Version and Version 1 of Ticket #10192, comment 3


Ignore:
Timestamp:
Mar 12, 2013, 9:47:35 AM (8 years ago)
Author:
Piotrek Koszuliński
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10192, comment 3

    initial v1  
    77* There is no reason for enter key to reuse indent plugin. This dependency is problematic, because enter key is popular (nearly obligatory plugin) whereas indent is less popular, but now it is required by the first one.
    88* However, it won't be a complete fix, because in order to be able to nest lists one would have to allow {{{margin-left}}} style. I can think of two solutions.
    9   * We can add a second part of requiredContent rule for indent plugin, checking whether lists are allowed. This is quick fix, but user will be able to indent block when only nesting lists is allowed.
    10   * Therefore second, but more complex part of this solution would be to make indent and outdent buttons contextual and aware of ACF setting. Command would be refreshed based on current context (if caret is in block or list item) and what's allowed (indenting block and/or list items). This part is pretty tough because there has to be 1:1 relation - if command is enabled and indenting blocks is not allowed, the it should always nest this list item, not indent some block. And vice versa.
     9  * We can add a second part of requiredContent rule for indent plugin, checking whether lists are allowed. This is a quick fix, but user will be able to indent block when only nesting lists is allowed.
     10  * Therefore second, but more complex part of this solution would be to make indent and outdent buttons contextual and aware of ACF setting. Command would be refreshed based on current context (if caret is in block or list item) and what is allowed (indenting block and/or list items). This part is pretty tough because there has to be 1:1 relation - if command is enabled and indenting blocks is not allowed, then it should always nest this list item, not indent some block. And vice versa.
    1111
    1212Question is - what can we include in 4.1 and what has to wait for... 4.2? I'm for the full solution now, because this thing will be pretty broken with partial approach.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy