Changes between Initial Version and Version 1 of Ticket #10664, comment 3


Ignore:
Timestamp:
Sep 10, 2013, 8:22:16 AM (7 years ago)
Author:
Piotrek Koszuliński
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10664, comment 3

    initial v1  
    22
    331. data.math - I'm not sure if this is a good name. It contains equation/formula's source and "math" seems to be meaningless.
    4 2. `data.math = el.children[ 0 ].value;` such careless traversing structure coming from data is unsafe. In this case (for some reason) it doesn't cause a problem, but some check what's there would be better.
     42. `data.math = el.children[ 0 ].value;` such careless traversing structure coming from data is unsafe. In this case it only causes displaying default equation, but some check what's there would be better and if span's content is corrupted we should rather not upcast it.
    553. getAbsolutePath - I've seen similar hack somewhere else. It'd be great to not have it inside widget.
    664. The code lacks comments.
© 2003 – 2020 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy