We are migrating CKEditor issue tracking to GitHub. Please, use GitHub to report any new issues.

The former tracking system (this website) will still be available in the read-only mode. All issues reported in the past will still be available publicly and can be referenced.

Important: we decided not to transfer all the tickets to GitHub, as many of them are not reproducible anymore or simply no longer requested by the community.
If the issue you are interested in, can be still reproduced in the latest version of CKEditor, feel free to report it again on GitHub.
At the same time please note that issues reported on this website are still taken into consideration when picking up candidates for next milestones.

To report a new issue, go to https://github.com/ckeditor/ckeditor-dev/issues and follow the instructions in the issue template.

Context Navigation

← Previous Change
Ticket Comment History
Next Change →

Changes between Initial Version and Version 1 of Ticket #10664, comment 3

Timestamp:: Sep 10, 2013, 8:22:16 AM (11 years ago)
Author:: Piotrek Koszuliński
Comment:

Legend:

: Unmodified
: Added
: Removed
: Modified

Ticket #10664, comment 3

initial	v1
2	2
3	3	1. data.math - I'm not sure if this is a good name. It contains equation/formula's source and "math" seems to be meaningless.
4		2. `data.math = el.children[ 0 ].value;` such careless traversing structure coming from data is unsafe. In this case ~~(for some reason) it doesn't cause a problem, but some check what's there would be better~~.
	4	2. `data.math = el.children[ 0 ].value;` such careless traversing structure coming from data is unsafe. In this case it only causes displaying default equation, but some check what's there would be better and if span's content is corrupted we should rather not upcast it.
5	5	3. getAbsolutePath - I've seen similar hack somewhere else. It'd be great to not have it inside widget.
6	6	4. The code lacks comments.