Changes between Version 2 and Version 3 of Ticket #10685, comment 22


Ignore:
Timestamp:
Jul 7, 2015, 12:38:59 AM (6 years ago)
Author:
Steve James
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10685, comment 22

    v2 v3  
    99I do not entirely agree with this approach for CKEditor.  I recognize this is considered a best practice regarding cache management by many, but my view is that it really is most applicable to resources in the folder structure that do not end up getting referenced via <a>/<img> tags in the content.
    1010
    11 A specific example would be the smileys.  A huge headache that I ran into was that I was ending up with a huge bunch of broken <img tags for smileys when upgrading from one ckeditor version to another and using the folder version approach.  (300,000+ users... major pain)  The reason, of course, was that the smileys are essentially content that is bundled with the editor builds, and they are inserted into the content via <img tags that reference their file folders in the current editor folder structure, *unless you specifically tell the editor to look in another folder location in the config*.  It took me a while to sort out isolating the smileys folder separate from the cke folder structure and setting the smiley folder location in the editor config.
     11A specific example would be the smileys.  A huge headache that I ran into was that I was ending up with a huge bunch of broken <img tags for smileys when upgrading from one ckeditor version to another and using the folder version approach.  (300,000+ users... major pain)  The reason, of course, was that the smileys are essentially content that is bundled with the smileys plugin in editor builds, and they are inserted into the content via <img tags that reference their file folders in the current editor folder structure, *unless you specifically tell the editor to look in another folder location in the config*.  It took me a while to sort out isolating the smileys folder separate from the cke folder structure and setting the smiley folder location in the editor config.
    1212
    1313Therefore, the folder version approach can cause problems for anything that the editor *inserts into the content* via a link or image tag that references bundled content in the current folder structure.  Since I do not know what types of content (beyond smileys) you may bundle with the editor in the future, ''I specifically choose not to use the folder version approach, and I am also very much in favor of using a version/timestamp query parameter instead.''  What I would prefer is that you include it as an version/timestamp value as "buried" default config setting that I can override via a config setting I specify--that will help with special cases where I may need to force a resource reload for my users.  (A specific example is forcing a reload for mono vs color toolbar icons.)
© 2003 – 2020 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy