Changes between Initial Version and Version 1 of Ticket #10750, comment 2


Ignore:
Timestamp:
Sep 4, 2015, 1:23:53 PM (7 years ago)
Author:
Jakub Ś
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10750, comment 2

    initial v1  
    1212First of all I think that that developer and not CKEditor should take care of quoting font names in {{{font_names}}} configuration option. CKEditor should however not lover-cased them (**there are case sensitive font names - #12492**) or remove quotes around them once added. IMO CKEditor should add font names as they are **to dropdowns and elements in content area**.
    1313[[BR]]
    14 Tickets #5966, #12563 as well as this ticket mention parseCssText as the culprit and the comment in that method seems to confirm it.
    15 There might be other places where font names are normalized. Anyway they should be the same everywhere.
     14Ticket #12563 as well as this ticket mention parseCssText as the culprit and the comment in that method seems to confirm it.
     15There might be other places where font names are normalized (See e.g. #5966). **Anyway they should be the same everywhere (style, font dropdowns and content).**
    1616
    1717NOTE: It is important to check if the font name is actually left as it was defined because in some cases browsers work well with minified and unquoted font-names.
     
    2121I have written:
    2222>First of all I think that that developer and not CKEditor should take care of quoting font names in {{{font_names}}} configuration option.
    23 Well at first I was thinking that perhaps editor could search for generic fonts and unquote them but that last note from specification blew me of the track thus leaving is to developer to define font names property might be best approach. We just should not modify anything.
     23Well at first I was thinking that perhaps editor could search for generic fonts and unquote them but that last note from specification blew me of the track thus leaving is to developer to define font names properly might be best approach. We just should not modify anything.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy