Changes between Initial Version and Version 1 of Ticket #10869, comment 13


Ignore:
Timestamp:
Oct 29, 2013, 10:20:31 AM (8 years ago)
Author:
Marek Lewandowski
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10869, comment 13

    initial v1  
    44I've used these attributes at the very begining but we decided with PK that allows us to deal this issue in more flexible and readable way. In addition to that we already have perfect spot to add widgets hiding, or anything (which imho is highly possible in future), with very little of work.
    55
     6As for me it's way to go, since:
     7- it has very good spot in single responsibility function
     8- it allows us to customize it very easily later on
     9
    610''it would be nice for widgets to show nice names like “image” or “placholder” (localizable)''
    711
    8 Its now achievable using pathName property, so we can create editor.lang.image2.pathName and assign it to definition if needed, but that sounds like next ticket after merging this one.
     12Its now achievable using pathName property, so we can create {{{editor.lang.image2.pathName}}} and assign it to definition if needed, but that sounds like next ticket after merging this one.
    913
    1014In fact, this mistake lead to dead code in plugins/link/[https://github.com/ckeditor/ckeditor-dev/blob/major/plugins/link/plugin.js#L213 plugin.js] where code can not ever execute.
© 2003 – 2021 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy