Changes between Initial Version and Version 1 of Ticket #10925, comment 30


Ignore:
Timestamp:
Apr 4, 2014, 1:54:35 PM (11 years ago)
Author:
Piotrek Koszuliński
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10925, comment 30

    initial v1  
    2525* https://github.com/cksource/ckeditor-dev/tree/8272a6a/plugins/mediaembed/plugin.js#L258-L266 - what is this code doing? A comment should explain what it is meant to do and why, no how it does this (good example: https://github.com/cksource/ckeditor-dev/tree/8272a6a/plugins/mediaembed/plugin.js#L272).
    2626
     27* There's no documentation for `config.mediaEmbed_output`. And the documentation for pasteStrategies and outputStrategies does not have any value for developer because it does not explain how it is related to the config option, the config option is not explained in terms of what does it change, and there's no explanation of what one can achieve adding new strategies. That's why we exposed them, so that must be documented.
     28
     29* The CKEDITOR.plugins.mediaembed should be marked as singleton.
     30
     31* The sample does not show mediaembed features. I miss stuff like - "paste this link and see what happens", "see - it can produce `<oembed>` tags", etc. The whole oembed concept needs to be explained too.
    2732
    2833== Important (can be done after first release)
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy