Changes between Initial Version and Version 1 of Ticket #10925, comment 40
- Timestamp:
- Dec 11, 2014, 9:41:23 AM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #10925, comment 40
initial v1 122 122 I've gathered my further questions below, just so it will be easier: 123 123 124 ## Review questions: 124 == Review questions: 125 125 126 * `evt.data.requestFunction` thing 126 127 * [https://github.com/cksource/ckeditor-dev/blob/1c341a206c5d2459c93585b7f0e5f28ba4c47732/plugins/mediaembed/plugin.js#L276] how do we want to handle this critical error (assuming that exception is not an option) 127 128 * Any good propositions for `fireMediaRequested`? 128 129 129 ##My own new ideas130 * I think that we can change button group for the button: 131 It's fair to put it next to the image button, though there is already a ton of buttons. : \130 == My own new ideas 131 132 * I think that we can change button group for the button:[BR]It's fair to put it next to the image button, though there is already a ton of buttons. : \ 132 133 * Change cache to work per editor instance. 133 134 Global cache is much more efficient, but you're going to face problems when you'll want to customize html output in only one instance.
