We are migrating CKEditor issue tracking to GitHub. Please, use GitHub to report any new issues.

The former tracking system (this website) will still be available in the read-only mode. All issues reported in the past will still be available publicly and can be referenced.

Important: we decided not to transfer all the tickets to GitHub, as many of them are not reproducible anymore or simply no longer requested by the community.
If the issue you are interested in, can be still reproduced in the latest version of CKEditor, feel free to report it again on GitHub.
At the same time please note that issues reported on this website are still taken into consideration when picking up candidates for next milestones.

To report a new issue, go to https://github.com/ckeditor/ckeditor-dev/issues and follow the instructions in the issue template.

Context Navigation

← Previous Change
Ticket Comment History
Next Change →

Changes between Initial Version and Version 1 of Ticket #11011, comment 10

Timestamp:: Nov 27, 2013, 10:09:26 AM (10 years ago)
Author:: Piotr Jasiun
Comment:

Legend:

: Unmodified
: Added
: Removed
: Modified

Ticket #11011, comment 10

initial	v1
2	2	> 1. Wouldn't `indexOf` be better than `substr`?
3	3
4		No. `indexOf` is slower, because if it does not find 'data-' at the beginning it will look for match. Anyway I replaced `substr`with `s~~ubstring~~` because the second one is standardized.
	4	No. `indexOf` is slower, because if it does not find 'data-' at the beginning it will look for match. Anyway I replaced `substr`with `slice` because the second one is standardized.
5	5
6	6	> 2. It would be good to have a test that even though data-* attr wasn't removed, the next one after it was, so we'll know that loop wasn't terminated completely.