We are migrating CKEditor issue tracking to GitHub. Please, use GitHub to report any new issues.

The former tracking system (this website) will still be available in the read-only mode. All issues reported in the past will still be available publicly and can be referenced.

Important: we decided not to transfer all the tickets to GitHub, as many of them are not reproducible anymore or simply no longer requested by the community.
If the issue you are interested in, can be still reproduced in the latest version of CKEditor, feel free to report it again on GitHub.
At the same time please note that issues reported on this website are still taken into consideration when picking up candidates for next milestones.

To report a new issue, go to https://github.com/ckeditor/ckeditor-dev/issues and follow the instructions in the issue template.

Context Navigation

← Previous Change
Ticket Comment History
Next Change →

Changes between Initial Version and Version 1 of Ticket #11186, comment 5

Timestamp:: Jan 8, 2014, 10:44:07 AM (11 years ago)
Author:: Olek Nowodziński
Comment:

Legend:

: Unmodified
: Added
: Removed
: Modified

Ticket #11186, comment 5

initial	v1
1	1	I pushed a minor commit to the test branch. Everything's fine except the name of the method. `addUpcastMethod` suggests that it's possible to extend the upcasting logic, while what we do here is a basic filtering (pre-filtering, actually). `addUpcastFilter` would be more convenient IMO.
	2
	3	[https://github.com/cksource/ckeditor-dev/commit/051ba52ce41eba90c76a01b343c49518eaf72b20#diff-d932030cd4e22ec8b0e30a362269b7e8R1640 This "empty" return] should be `return false`, right?