Changes between Initial Version and Version 1 of Ticket #11460, comment 16


Ignore:
Timestamp:
Feb 27, 2014, 8:02:35 PM (6 years ago)
Author:
Piotrek Koszuliński
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11460, comment 16

    initial v1  
    11> I'm not sure if we can "fix" range#cloneContents() or we need to write it from scratch. What cloneContents() basically do is calling execContentsAction what is pretty complex function used also by some other functions. This function was designed that way it can change range, so it might happen. And if we would need to write new range.cloneContents method just to use it in selection.getSelectedHTML maybe we should focus on getSelectedHTML. If it really need range.cloneContents we should write it but this is not a method we should focus on.
    22
    3 I'm actually curious how cloneContents work currently. There's a slight chance that it was intended to be used in such cases - it's hard to tell now. But even if not, implementing it from scratch is acceptable. Note that implementing getSelectedHtml **requires** having something similar to cloneContents (even in [[attachment:​readHtmlOnDragstart.html​]] you used cloneContents, although a native one).
     3I'm actually curious how cloneContents works currently. There's a small chance that it was intended to be used in such cases - it's hard to tell now. But even if not, implementing it from scratch is acceptable. Note that implementing getSelectedHtml **requires** having something similar to cloneContents (even in [[attachment:​readHtmlOnDragstart.html​]] you used cloneContents, although a native one).
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy