Changes between Initial Version and Version 1 of Ticket #11461, comment 12
- Timestamp:
- Dec 8, 2014, 10:52:22 AM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #11461, comment 12
initial v1 13 13 * it should be `CKEDITOR.fileTools.fileLoader`. 14 14 * Is `fileLoader` an appropriate class name at all? It handles loading and uploading, so the wider `fileUploader` name seems to fit better. 15 * The `fileLoader` class misses a step by step usage example pretty badly. It is unclear how it can be used. The reason may also be that all its method are public, while I believe that only `upload`, `loadAndUpload` and `load` are really useful. If I'm right, then please mark the rest as private. Still - a typical code sample would be great.15 * The `fileLoader` class misses a step by step usage example pretty badly. It is unclear how it can be used. The reason may also be that all its methods are public, while I believe that only `upload`, `loadAndUpload` and `load` are really useful. If I'm right, then please mark the rest as private. Still - a typical code sample would be great. 16 16 17 17 === uploadwidget/plugin.js: === 18 18 19 19 * What is it for? `editor.filter.allow( '*[!data-widget,!data-cke-upload-id]' );` 20 * Hard to say w ayyou tried to say (perhaps: "paste event listener which handles pasted and dropped files"): https://github.com/cksource/ckeditor-dev/blob/978a9a514/plugins/uploadwidget/plugin.js#L2320 * Hard to say what you tried to say (perhaps: "paste event listener which handles pasted and dropped files"): https://github.com/cksource/ckeditor-dev/blob/978a9a514/plugins/uploadwidget/plugin.js#L23 21 21 * On pasted what? https://github.com/cksource/ckeditor-dev/blob/978a9a514/plugins/uploadwidget/plugin.js#L29 22 22 * No idea again what does it mean and when does it happen? https://github.com/cksource/ckeditor-dev/blob/978a9a514/plugins/uploadwidget/plugin.js#L53
