Changes between Version 1 and Version 2 of Ticket #11461, comment 6


Ignore:
Timestamp:
Aug 31, 2014, 11:44:30 AM (10 years ago)
Author:
Piotrek Koszuliński
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11461, comment 6

    v1 v2  
    5252 - problem 2 can be fixed with 1 line of code (downcast method will return an empty text node),
    5353 - problem 3 can be fixed out of the box,
    54  - problem 4 will be partially fixed, because uploading image will be in non-contenteditable so it won't be uploaded for the second time.
     54 - problem 4 will be partially fixed, because uploading image will be in non-contenteditable so it won't be uploaded for the second time [[Reinmar: Not true. Since on copy we (will) take downcasted widget the copy will... do nothing. It's not that bad, but it means that downcasting on copy/drag should behave differently and we don't yet have a way to achieve this. The plan was to use `dataProcessor.toDataFormat()`, however, it'd not be semantically correct, because data !== HTML, so we should not pack data into clipboard. We need a third processing method in dataProcessor. This reminds me about #10204 and I'm willing to introduce it.]].
    5555 - we can encapsulate code related to image uploading: paste event just mark images as "to upload" and `widget.upcast` method will handle it.
    5656
    57 In general uploading image is not just an image, it should be thread differently as a special part of the document so widget seems to be logically good solution.
     57In general uploading image is not just an image, it should be treated differently as a special part of the document so widget seems to be logically a good solution.
    5858
    59 Also with the widgets and with expected behavior described above we can easily show additional information like upload progress.
     59Also, with the widgets and with the expected behavior described above we can easily show additional information like upload progress. [[Reinmar: We still have to remember about undo manager, so any solution that involves changes in DOM should be avoided. Though, canvas may be a rescue.]]
    6060
    6161==== Upload manager:
    6262
    63 To handle undo/redo we need an upload manager which will keep id's and progress of uploads so when user execute undo command manager will update paths.
     63To handle undo/redo we need an upload manager which will keep id's and progress of uploads so when user executes undo command manager will update paths.
    6464
    6565== Conflicts: ==
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy