Changes between Initial Version and Version 1 of Ticket #11480, comment 17
- Timestamp:
- Mar 27, 2014, 10:06:22 AM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #11480, comment 17
initial v1 18 18 18. Use camel case: https://github.com/cksource/ckeditor-dev/blob/t/11480/plugins/codesnippetgeshi/plugin.js#L51 19 19 19. https://github.com/cksource/ckeditor-dev/blob/t/11480/plugins/codesnippet/plugin.js#L79 Why is this an CKEDITOR's object? This should be placed in `editor.plugins.codesnippet` by simply defining these methods in plugin definition. The reason is that those methods modifies editor instance, not CKEDITOR object. 20 20. In the sample - make the "Remaining part is resposible.." (BTW. typo) more visible, because now it looks too much like editors' startup logic. 21 21. The toolbars can indeed be simplified.