Changes between Version 1 and Version 2 of Ticket #11663, comment 9


Ignore:
Timestamp:
Jun 22, 2015, 12:14:33 PM (4 years ago)
Author:
Szymon Cofalik
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11663, comment 9

    v1 v2  
    11Fixed on branch:t/11663
    22
    3 I've also pushed branch:t/11663b and branch:t/11663c with alternative solutions (these are not refactored, just proof-of-concept). These solutions should be more accurate when determining content height.
     3I've also pushed branch:t/11663b and branch:t/11663c with alternative solutions (these are not refactored, just proof-of-concept). These solutions should be more accurate when determining content height. However this ticket is fixed by branch:t/11663 so we can move this discussion to another ticket.
    44
    55branch:t/11663 will return wrong height only when top or bottom-expanding element has margin bigger than `body` margin. The error will be between 0 and `marginTop` + `marginBottom` of body (by default these are 20px so max error will be 40px).
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy