Changes between Initial Version and Version 2 of Ticket #12332


Ignore:
Timestamp:
Sep 8, 2014, 8:03:30 AM (7 years ago)
Author:
Piotrek Koszuliński
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12332

    • Property Status changed from new to confirmed
  • Ticket #12332 – Description

    initial v2  
    11This is a follow up of #12327.
    22
    3 Current implementation is really fragile to canceling events. Eg. a developer might cancel keydown event for whatever reason, and undo will not perform preparation code.
     3Current implementation is really fragile to code execution order. If undo manager is initialised before some code that cancels keydown undo manager's listener will be executed, but if the order is opposite, then it won't.
    44
    5 Our goal priority should be below default {{{10}}}.
     5The listeners should be added with low priorities (999), so they are always handled at the end - if nothing else handled them.
© 2003 – 2021 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy