Changes between Initial Version and Version 1 of Ticket #12484, comment 4
- Timestamp:
- Sep 30, 2014, 1:01:41 PM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #12484, comment 4
initial v1 1 I noticed problem in iterator. From what I see it does not respect whether while iterating nodes it is still in editable area. To fix this issue I added extra check which prevent iterating out of editor scope in [https://github.com/cksource/ckeditor-dev/commit/053d0ec014b504f24c96374e0bacc40ca895a696#diff-73e72bec31b467da2eb67d7823adbe28R106 here]. I already fixed it in [https://github.com/cksource/ckeditor-dev/commit/053d0ec014b504f24c96374e0bacc40ca895a696 commit]. But it's hard to restore issue in tests - it just simply works.1 I noticed problem in iterator. From what I see it does not respect whether while iterating nodes it is still in editable area. To fix this issue I added extra check which prevent iterating out of editor scope in [https://github.com/cksource/ckeditor-dev/commit/053d0ec014b504f24c96374e0bacc40ca895a696#diff-73e72bec31b467da2eb67d7823adbe28R106 here]. I already fixed it in [https://github.com/cksource/ckeditor-dev/commit/053d0ec014b504f24c96374e0bacc40ca895a696 commit]. But it's hard to restore issue in tests - it just simply pass but should fail. 2 2 3 There are differences between test code and clicking by mouse in selecting all elements:3 There are differences between test code (executing 'selectAll' command) and selecting all content by mouse: 4 4 5 5 {{{
