Changes between Initial Version and Version 1 of Ticket #12618, comment 15


Ignore:
Timestamp:
Jun 1, 2015, 9:45:43 AM (6 years ago)
Author:
Piotr Jasiun
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12618, comment 15

    initial v1  
    1 We decided that solution should be more generic, because this is a problem we have with every widget: some commands does not make sense when widget is focused. Instead of having [https://github.com/cksource/ckeditor-dev/blob/1f8744a63f2f73a71f3d6bc9480d4763c908eba7/plugins/uploadwidget/plugin.js#L404 hardcoded list of disabled commands] [https://github.com/cksource/ckeditor-dev/blob/1f8744a63f2f73a71f3d6bc9480d4763c908eba7/plugins/uploadwidget/plugin.js#L403-L438 this logic] should be moved to the widget plugin and list of commands should be in a widget definition property.
     1We decided that solution should be more generic, because this is a problem we have with every widget: some commands does not make sense when widget is focused. Instead of having [https://github.com/cksource/ckeditor-dev/blob/1f8744a63f2f73a71f3d6bc9480d4763c908eba7/plugins/uploadwidget/plugin.js#L404 hardcoded list of disabled commands], [https://github.com/cksource/ckeditor-dev/blob/1f8744a63f2f73a71f3d6bc9480d4763c908eba7/plugins/uploadwidget/plugin.js#L403-L438 this logic] should be moved to the widget plugin and list of commands should be in a widget definition property.
    22
    3 I am not sure on what level we should disable commands: this should we a list of commands, toobarGroups or toolbars and if it should be white- or black-list and I do not remember what we decided. We can not easily decide what command makes sense in each context: `about` command should be active always, justify should be disabled for upload widget, but list (which also works on the paragraph) could be available.
     3I am not sure on what level we should disable commands: this should we a list of commands, toobarGroups or toolbars and if it should be a white- or black-list and I do not remember what we decided. We can not easily decide which command makes sense in each context: `about` command should be active always, `justify*` should be disabled for upload widget, but `*list` (which also works on the paragraph) could be available.
    44
    55I think we should focus on solving current case which is conflict between upload widget and justify in image2 and do not make too generic solutions. So the widget property should simply have the list of commands which should be disabled when widget is focused:
© 2003 – 2021 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy