Changes between Version 1 and Version 2 of Ticket #12621, comment 7


Ignore:
Timestamp:
Nov 10, 2014, 7:30:56 PM (4 years ago)
Author:
Piotrek Koszuliński
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12621, comment 7

    v1 v2  
    442. When `selection.selectRanges` is executed it checks whether the selection needs a filling char. **Note:** by "correct" I mean that it has not changed recently, although it is a bug that the `removeFromRange()` method does not remove the empty inline element.
    553. In this case the algorithm (implemented by the `rangeRequiresFix` function) should find that the range is placed right after `<strong>\u200b</strong>` and return true - the range requires the filling char.
    6 4. For some odd reason the algorithm uses the `walker.invisible()` method. Apparently it did return `true` for the `<strong>\u200b</strong>` element. But it does not do this anymore.
     64. For some odd reason the algorithm uses the `walker.invisible()` method. Apparently it did return `false` for the `<strong>\u200b</strong>` element. But it does not do this anymore.
    77
    88Plan:
    99
    10 1. We need tests for `walker.invisible()` to verify that behaviour of this method really changed for the above scenario. The expected result is `false`, so if the method returns this value, then it should not be touched.
     101. We need tests for `walker.invisible()` to verify that behaviour of this method really changed for the above scenario. The expected result is `true`, so if the method returns this value, then it should not be touched.
    11112. We need to fix the `rangeRequiresFix` function which should not be based on previous quirky behaviour of the `walker.invisible()` method.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy