Changes between Version 2 and Version 3 of Ticket #12842, comment 1


Ignore:
Timestamp:
Jan 22, 2015, 2:25:36 PM (5 years ago)
Author:
Piotr Jasiun
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12842, comment 1

    v2 v3  
    1 I tried fix [https://github.com/cksource/ckeditor-dev/blob/322bc70f9784f4e70c967aca3d1f92bb200aa007/plugins/pastefromword/filter/default.js#L775-L776 this condition] what fix missing `<s>` and `<u>` over multiple spaces and do not break exiting tests (the problem is that empty block also contains only &nbsp; which should not be underlined/struck in this case). Also I have added support to the `<strike>` element, because in same cases pasted content contains `<strike>` instead of `<s>`. But these is still some problems (see [[Image(ticket:12842:Screenshot%20from%202015-01-22%2014%3A50%3A19.png)]]). This is not because of mentioned condition nor because of  `isContainingOnlySpaces` method, but was fine before #12750. Also I am not able to easily merge contiguous text nodes now, because the can be wrapped in various tags.
     1I tried fix [https://github.com/cksource/ckeditor-dev/blob/322bc70f9784f4e70c967aca3d1f92bb200aa007/plugins/pastefromword/filter/default.js#L775-L776 this condition] what fix missing `<s>` and `<u>` over multiple spaces and do not break exiting tests (the problem is that empty block also contains only &nbsp; which should not be underlined/struck in this case). Also I have added support to the `<strike>` element, because in same cases pasted content contains `<strike>` instead of `<s>`. But there is still some problems (see [[Image(ticket:12842:Screenshot%20from%202015-01-22%2014%3A50%3A19.png)]]). This is not because of mentioned condition, nor because of `isContainingOnlySpaces` method and was fine before #12750. Also I am not able to easily merge contiguous text nodes now, because they can be wrapped in various tags.
    22
    33Now my idea is to use `moveToText` on the second run of filter when the whole clean up is already done. It may fix both problems.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy