Changes between Initial Version and Version 1 of Ticket #12870


Ignore:
Timestamp:
Jan 29, 2015, 11:17:43 AM (9 years ago)
Author:
Piotr Jasiun
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12870

    • Property Milestone changed from to CKEditor 4.5.0
  • Ticket #12870 – Description

    initial v1  
    1 Since we have notifications we should no more use `alert()` function in out code and use warning notification instead.
     1Since we have notifications we can replace some usage of `alert()` method with warning notification. I found 3 potential places where we could change it:
     2
     3 - https://github.com/ckeditor/ckeditor-dev/blob/major/plugins/clipboard/plugin.js#L640
     4 - https://github.com/ckeditor/ckeditor-dev/blob/major/plugins/pastefromword/filter/default.js#L1162
     5 - https://github.com/ckeditor/ckeditor-dev/blob/major/plugins/filebrowser/plugin.js#L342
     6
     7Warning notification could be used if notification plugin is loaded and `alert` function otherwise.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy