Changes between Version 20 and Version 21 of Ticket #12875, comment 4
- Timestamp:
- Feb 11, 2015, 1:01:30 PM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #12875, comment 4
v20 v21 15 15 1. **DONE:** We don't need the "Toggle editable" button. 16 16 1. **DONE** **Olek:** It would be good if toolbar buttons were not clickable. I checked that setting `pointer-events: none` on the toolbar element seems to be enough. 17 1. It's useful that the tool's width is proportional to window size - thanks to that one can check how the toolbar will behave in different widths.17 1. **DONE?** It's useful that the tool's width is proportional to window size - thanks to that one can check how the toolbar will behave in different widths. 18 18 1. The "others" group could be displayed in the table (https://github.com/cksource/incubator/issues/5). 19 19 1. **DONE:** In the basic toolbar editor change "Separator" to "Row separator" or something similarly meaningful. … … 24 24 1. **REVIEW Artur:** The toolbar editor should not jump on every change. It can be fixed by setting a minimum height on an element that contains the toolbar. 25 25 1. **DONE Artur** The page with toolbar editor should not scroll up when changing the order of groups. 26 1. There is no visual indication (outline) that up/down arrows are focused when using keyboard.26 1. **Artur** There is no visual indication (outline) that up/down arrows are focused when using keyboard. 27 27 1. Highlighting toolbar groups on hover works only with small toolbars on big screens. With full toolbar (used by up to 50% of users) it is impossible to see the bottom groups highlighted on a toolbar after scrolling the page. 28 1. Highlighting toolbar groups does not work on tablets or when one is using keyboard navigation only.28 1. **Artur** Highlighting toolbar groups does not work on tablets or when one is using keyboard navigation only. 29 29 1. **Olek** Check the style of "Unused elements" in Advanced configurator. 30 30 1. **DONE** Bug: "Move up" button of a separator added without a context is enabled, though its the very first element of the list. … … 36 36 1. **DONE** I guess that look of the basic sample should be inspired by the SDK. 37 37 1. For the config section we chose `uiColor` and `height` which should cover 99.9% cases. We decided to place there entire code with `CKEDITOR.editorConfig = functio() {};`, so the text description must be updated accordingly. 38 1. Some users may look into basic sample's source code to see how the editor is initialised. This code is pretty complex due the compatibility checks. Therefore we can leave in comments some explanation why so and how to replace a simple textarea (important - code of the textarea should also be included). 39 1. Warning box below an editor should be displayed if the package doesn't include the `wysiwygarea` plugin. It should explain that without this plugin the classic mode will not work although inline editors and `divarea`-based ones will. 38 1. **Artur** Some users may look into basic sample's source code to see how the editor is initialised. This code is pretty complex due the compatibility checks. Therefore we can leave in comments some explanation why so and how to replace a simple textarea (important - code of the textarea should also be included). 39 1. **Artur** Warning box below an editor should be displayed if the package doesn't include the `wysiwygarea` plugin. It should explain that without this plugin the classic mode will not work although inline editors and `divarea`-based ones will. 40 `<div class="tip">` from SDK should do the trick. 41 40 42 1. **DONE** The text content of the sample that I created is already outdated. See Ania's document for the most recent version. 41 43 42 44 == Old samples == 43 45 44 1. We need a very well visible box with info that this is old, deprecated sample (the same about the index). Links to the basic sample and an appropriate sample in the SDK should be included. 46 1. **DONE?** **Artur** We need a very well visible box with info that this is old, deprecated sample (the same about the index). 47 1. Links to the basic sample and an appropriate sample in the SDK should be included. 45 48 46 49 == Documentation review ==
