Changes between Version 2 and Version 3 of Ticket #12875, comment 4
- Timestamp:
- Feb 2, 2015, 9:58:42 AM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #12875, comment 4
v2 v3 6 6 1. The basic sample should link to the basic toolbar editor (the graphical one) which should link to the advanced one. 7 7 1. Both editors need short description how to use them. 8 1. Both editors' UX and UI must be polished.8 1. **Olek:** Both editors' UX and UI must be polished. 9 9 1. Check whether the glyphs font used in the basic editor has the right license. We may also need to create a file in its directory with credits and its license. 10 10 1. The same as above about the CodeMirror and plugins used with it. 11 11 1. Update CodeMirror if it got any updates. Also, I would consider installing it and the plugins we use through npm. 12 12 1. Both editors should by default load the toolbar layout that is actually set (which editor would use). Now they load all buttons in one row which is not true for normal editor. See the old toolbar sample to learn how to read toolbar layout. 13 1. There's some error thrown right now.13 1. **DONE:** There's some error thrown right now. 14 14 1. **DONE:** We don't need the "Toggle editable" button. 15 1. It would be good if toolbar buttons were not clickable. I checked that setting `pointer-events: none` on the toolbar element seems to be enough.15 1. **Olek:** It would be good if toolbar buttons were not clickable. I checked that setting `pointer-events: none` on the toolbar element seems to be enough. 16 16 1. It's useful that the tool's width is proportional to window size - thanks to that one can check how the toolbar will behave in different widths. 17 17 1. The "others" group could be displayed in the table (https://github.com/cksource/incubator/issues/5). 18 18 1. In the basic toolbar editor change "Separator" to "Row separator" or something similarly meaningful. 19 1. Reduce number of scrolls in the basic editor - there should be only one (I have two right now). (The floating toolbar makes sense.)19 1. **Olek:** Reduce number of scrolls in the basic editor - there should be only one (I have two right now). (The floating toolbar makes sense.) 20 20 1. To be checked - how the toolbar editors read toolbar groups? What happens if one of loaded plugins defines its own group? What if it does and if `config.toolbarGroups` is set? This may be related - https://github.com/cksource/incubator/issues/4. 21 21 1. Toolbar editors should be checked on older IEs and if we have compatibility problems with something like IE10- we may just add there an alert that this browser is not supported.
