Changes between Initial Version and Version 5 of Ticket #12932


Ignore:
Timestamp:
Feb 16, 2015, 10:38:14 AM (5 years ago)
Author:
Jakub Ś
Comment:

To use Retina there is nothing more than I have written. You use hidpi property and have correct folder structure with 2x icons. These icons will be loaded on display which supports Retina.


The Plugin SDK document told me to use the 'icons' dictionary item to plugins.add.

I have absolutely no idea what you are talking about (what is icon dictionary?). Perhaps if you would have shown it in code, it would be more understandable.

About icons. I'm not sure if this is what you had problem with but:

When using below, icon name has to be the same as button name and starting with lower case.

CKEDITOR.plugins.add( pluginName, {
 icons: 'buttonName',

Another way to add icon to editor is (in this case name of the icon is what you imagine):

editor.ui.addButton && editor.ui.addButton( 'ButonName', {
 icon: this.path + 'images/icon.png'

I have told you about some code example. I don't think however that it is necessarry because icons are not related to retina support in this case and I would like to keep this ticket clean.


  1. Formally document hidpi development - missing and we have this confirmed
  2. Support hidpi with addButton icon specification - it is not related. Correct icon gets loaded on proper display.
  1. Document addButton better
  2. Fix the Plugin SDK document to say how custom icons can be referenced (i.e. via addButton)

I believe it is documented properly. If not, please open new ticket for it.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12932

    • Property Status changed from new to confirmed
    • Property Component changed from UI : Toolbar to Documentation & Samples
  • Ticket #12932 – Description

    initial v5  
    1010
    1111If I am missing something, please let me know. Perhaps for example somehow retina support is compiled in at build-time only and for sprites only, with it auto-searching the filesystem when building the sprites. I don't know, because I think it's not documented ;-).
     12
     13----
     14We are missing document explaining how to support Retina. Please see comment:2 for more details.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy