Changes between Initial Version and Version 1 of Ticket #12955, comment 3


Ignore:
Timestamp:
Feb 20, 2015, 8:39:56 AM (6 years ago)
Author:
Piotr Jasiun
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12955, comment 3

    initial v1  
    1 In fact I think that using redundant data is a bad smell. Is there any reason to store `_totalWeights` in the separate variable, not counting it every time based on `_tasks`? Such variables may be introduce to fix some performance issue, but it should be added when the fragment of code met performance problem, not before, "just in case". Otherwise we can have bugs like this.
     1I think that using redundant data is a bad smell. Is there any reason to store `_totalWeights` in the separate variable, not counting it every time based on `_tasks`? Such variables may be introduce to fix some performance issue, but it should be added when the fragment of code met performance problem, not before, "just in case". Otherwise we can have bugs like this.
© 2003 – 2021 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy