We are migrating CKEditor issue tracking to GitHub. Please, use GitHub to report any new issues.

The former tracking system (this website) will still be available in the read-only mode. All issues reported in the past will still be available publicly and can be referenced.

Important: we decided not to transfer all the tickets to GitHub, as many of them are not reproducible anymore or simply no longer requested by the community.
If the issue you are interested in, can be still reproduced in the latest version of CKEditor, feel free to report it again on GitHub.
At the same time please note that issues reported on this website are still taken into consideration when picking up candidates for next milestones.

To report a new issue, go to https://github.com/ckeditor/ckeditor-dev/issues and follow the instructions in the issue template.

Context Navigation

← Previous Change
Ticket Comment History
Next Change →

Changes between Initial Version and Version 1 of Ticket #12955, comment 3

Timestamp:: Feb 20, 2015, 8:39:56 AM (9 years ago)
Author:: Piotr Jasiun
Comment:

Legend:

: Unmodified
: Added
: Removed
: Modified

Ticket #12955, comment 3

initial	v1
1		I~~n fact I~~ think that using redundant data is a bad smell. Is there any reason to store `_totalWeights` in the separate variable, not counting it every time based on `_tasks`? Such variables may be introduce to fix some performance issue, but it should be added when the fragment of code met performance problem, not before, "just in case". Otherwise we can have bugs like this.
	1	I think that using redundant data is a bad smell. Is there any reason to store `_totalWeights` in the separate variable, not counting it every time based on `_tasks`? Such variables may be introduce to fix some performance issue, but it should be added when the fragment of code met performance problem, not before, "just in case". Otherwise we can have bugs like this.