Links to images with space are broken due to being encoded twice

[Wiktor Walc]

CKEditor should not encode URLs that it receives from the server connector due to problems described in ​http://dev.ckeditor.com/ticket/5527

Currently, when dragging an image into CKEditor called foo bar.jpg, the (valid) response from CKFinder is:

{"fileName":"foo bar.jpg","uploaded":1,"url":"\/ckfinder\/userfiles\/files\/foo%20bar.jpg"}

unfortunately, the end result in CKEditor is:

<img src="/ckfinder/userfiles/files/foo%2520bar.jpg" style="height:480px; width:640px" />

See that the space is encoded twice.

[Jakub Ś]

I believe the same thing is happening for UTF-8 characters lie ą ę ń etc.

In my case both files - with space or UTF-8 characters are not recognized. @pjasun told me that it should have been fix already.
@wwalc could you check if you are getting the same with UTF-8 characters?

[Piotr Jasiun]

It was fixed but wwalc changes his mind every 3 weeks to keep us busy ;P

This encodeURI most probably should be removed: ​https://github.com/ckeditor/ckeditor-dev/blob/major/plugins/filetools/plugin.js#L177

[Artur Delura]

To write manual tests ​benderjs:benderjs#190 should be closed.

[Artur Delura]

Changes in ​branch:t/13030. Unfotunatelly I can't run bender tests (branch dev).

[Piotrek Koszuliński]

The manual test was broken, because it always loaded the lena.jpg file. What's worse - there's no single automated test for this change.

[Artur Delura]

I have written automated test for issue changes in the same ​branch:t/13030.

[Piotrek Koszuliński]

The test passed on major.

[Piotrek Koszuliński]

My bad - it fails on major. It must have been cache or sth.

[Piotrek Koszuliński]

Fixed on major with ​git:b0d867d.