Changes between Initial Version and Version 1 of Ticket #13119, comment 3
- Timestamp:
- Mar 30, 2015, 4:55:59 PM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #13119, comment 3
initial v1 8 8 In my opinion links cause the biggest problem. We don't have right not a rule with specificty 11+ which clean them. Another tag which I saw touched is the sourceare and that's because it's not inside any `cke_reset_all` element. 9 9 10 I pushed branch:t/13119 with a manual test in which I styled content accordingly to the above rules - that we can't be bulletproof, but we can do better with specific elements rules (I chose only link and textarea) which have specificity 11 .10 I pushed branch:t/13119 with a manual test in which I styled content accordingly to the above rules - that we can't be bulletproof, but we can do better with specific elements rules (I chose only link and textarea) which have specificity 11 and set some reasonable (popular) styles. 11 11 12 12 I also made necessary changes to our reset.css (added `.cke_reset_all a, .cke_reset_all textarea` rules) and tuned related rules so they have specificity of 11+ too. 13 13 14 WDYT about the above? 14 WDYT about the above? Please remember that the patch is not meant to solve all problems, but simply improve the situation for most common scenarios. 15 15 16 16 PS. This small research was pretty interesting and was a good lesson that we could use when working on CKEditor 5 or any new skin that we'll build. It proves that CSS reset should be based on rules of specificity 11+ for as many elements that we use in our UI as possible. It can't be done for moono or kama now, because if I added `.cke_reset_all span` for instance it would make all other rules based on classes only (specificty = 10) ignored.
