Changes between Initial Version and Version 5 of Ticket #13200


Ignore:
Timestamp:
Oct 13, 2015, 3:26:48 PM (9 years ago)
Author:
Marek Lewandowski
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13200

    • Property Status changed from new to confirmed
    • Property Summary changed from Widget styling - review to [Umbrella] Widget styling - review
    • Property Milestone changed from to CKEditor 4.6.0
  • Ticket #13200 – Description

    initial v5  
    1 == Inability to achieve certain styling due to lack of class on widget wrappers ==
     1This issue covers styling enhancements. It includes:
    22
    3 Currently widget classes are applied to widget elements. This makes it impossible to achieve various results - e.g. http://stackoverflow.com/questions/29704019/how-to-floatleft-a-container-with-an-image-having-a-relative-width
    4 
    5 We wanted to keep classes on elements because we thought that it allows to create the same stylesheets for the content inside editor and outside. Unfortunately, due to the wrappers and CSS's limited capabilities it makes it impossible to achieve some pretty standard results.
    6 
    7 Note, that it will not be that uncommon to move classes to the wrapper because e.g. image2 already moves alignment classes there. It's a pity that we didn't learn from that fact earlier ;/.
    8 
    9 == Inability to write s rule matching certain widget wrapper + widget class ==
    10 
    11 Once classes will be moved to wrappers it would be good if it was possible to write rules like:
    12 
    13 {{{
    14 .image.centered { ... }
    15 .embed.centered { ... }
    16 }}}
    17 
    18 As I experienced recently centered image's wrapper may need very different styles than that of an embed widget. E.g. image's wrapper must have `text-align: center`. This affects embed widgets which may be unwanted if we only want to use `margin-left/right: auto`.
    19 
    20 Hence, it will be useful if widget wrapper had classes based on widgets names - e.g. "widget-image", "widget-embed", etc.
    21 
    22 == Lack of style exclusion (ability to automatically toggle styles) ==
    23 
    24 This is a feature of the styles system which is highly missed. It is not possible to create two styles like "width 50%" and "width 75%" that will not be applicable together. The styles system should toggle between them. This feature is missing in general, but it is most important for object (incl. widget) styles. Also, it is possible to implement it for widgets only due to a separate, simplistic (class based) styles handler.
     3* #13818 - Allow to link widget style definitions, so applying one style might disable the other
     4* #13828 - Widget classes should be added to wrapper rather than widget element
     5* #13829 - Add class based on widget type to the widget wrapper
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy