Changes between Initial Version and Version 1 of Ticket #13284, comment 14
- Timestamp:
- Jul 24, 2015, 1:52:16 PM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #13284, comment 14
initial v1 1 1 Unfortunately I cannot review this ticket and #13513. It's too many changes, too many mentioned TCs, but too few tests supporting them. 2 2 3 The rule is that if possible (and in this case it must be possible if you were able to reproduce all the problems) each change should have a test. It must be clear why it was made and it must be testable, otherwise I have no way to verify whether it's good and whether it's the only possible way.3 The rule (especially important in case of so complex systems) is that if possible (and in this case it must be possible if you were able to reproduce all the problems) each change should have a test. It must be clear why it was made and it must be testable, otherwise I have no way to verify whether it's good and whether it's the only possible way. 4 4 5 5 For instance, there's git:47ba21f103. How am I supposed to verify it? To verify that such case really takes place? I need a MT (or AT if possible, but I don't think it will be possible in this case) where I can see that this specific change fixed something.