Changes between Initial Version and Version 1 of Ticket #13284, comment 15


Ignore:
Timestamp:
Jul 27, 2015, 10:46:54 AM (10 years ago)
Author:
Szymon Cofalik
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13284, comment 15

    initial v1  
    11I've pushed branch:t/13284b.
    22
    3 1) I dropped ​git:47ba21f103 and ​git:e614c0a1 commits that you have mentioned. As you've written, these were general fixes to the selection mechanism. Since #13513 I think that these are overcomplicated. Solution from #13513 fixes them too.
     31) I dropped ​git:47ba21f103 and ​git:e614c0a1 commits that you have mentioned. As you've written, these were general fixes to the selection mechanism. Since #13513 I think that these are overcomplicated. Solution from #13513 achieves the same.
    44
    552) As for ​git:e191f4be - I described it in one of previous comments. I expanded comment in the code so it is more insightful but in-depth explanation is too long so I will leave it on a trac.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy