Changes between Version 3 and Version 4 of Ticket #13284, comment 9


Ignore:
Timestamp:
Jul 27, 2015, 10:30:36 AM (4 years ago)
Author:
Szymon Cofalik
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13284, comment 9

    v3 v4  
    33git:e191f4be
    44[[BR]]
    5 Fixes drag and drop prevention when selection was on ZWS. I had to prevent moving selection to a `fillingChar` in an elegant way and this is best solution I came up with. Reasoning behind it is this: let's assume that user have selection other than on widget. Then,
     5Fixes drag and drop prevention when selection was on ZWS. I had to prevent moving selection to a `fillingChar` in an elegant way and this is best solution I came up with. If I clear the selection, "fillingChar" mechanism will not fire.
     6
     7Does it break UX for a user? Let's assume that the user have selection other than on dragged widget. Then:
    68* if they just click on drag handler, they focus the widget,
    79* if they mousedown and click, they focus the widget.
    8 So no matter what the user does, they lose selection anyway. The only difference might be for snapshots but from my tests it doesn't affect undo manager.
    9 [[BR]]
     10
     11So no matter what the user does, they will "lose" current selection anyway. The only difference might be for snapshots but from my tests it doesn't affect undo manager.
     12
    1013'''Note:''' this commit alone fixes bug described in this ticket, but the first commit also fixes a bug (and fixes #13389)
    11 [[BR]]
     14
    1215'''Note:''' if you know there might be other similar cases in other parts of code, let me know.
    1316
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy