Cut reverse notes

[Piotr Jasiun]

1. Open: samples/old/replacebycode.html
2. Select from the begging to 'Americans' ([<h1>Apollo 11<h1><p>Apollo 11 was the spaceflight that landed the first humans,])
3. Press Ctrl+X.

Result:

1. the <p> is changed to <h1> (what is not that bad)
2. all nodes in the paragraph are in the REVERS order (what is the biggest WTF of the week)

So we have:

, on the Moon on July 20, 1969, at 20:18 UTC. Armstrong became the first to step onto the lunar surface 6 hours later on July 21 at 02:56 UTC.Buzz Aldrin and Neil Armstrong Americans

instead of:

, Americans Neil Armstrong and Buzz Aldrin, on the Moon on July 20, 1969, at 20:18 UTC. Armstrong became the first to step onto the lunar surface 6 hours later on July 21 at 02:56 UTC.

Reproduced on Opera, Chrome and Firefox, so wherever we have custom "Cut" handling.

[Szymon Cofalik]

After bisecting first bad commit is: ​git:039322aeab

[Artur Delura]

Simpified case:

1. Open editor with following content and selection:

   <div>[Apollo 11</div>
   
   <p><strong>foo</strong> bar <a href="http://en.wikipedia.org/wiki/Neil_Armstrong">baz</a> ]ban <a href="http://en.wikipedia.org/wiki/Buzz_Aldrin">buz</a></p>
   

2. Press Ctrl + X

Result:

<p><a href="http://en.wikipedia.org/wiki/Buzz_Aldrin">buz</a>ban </p>

Expected result:

<p>ban <a href="http://en.wikipedia.org/wiki/Buzz_Aldrin">buz</a></p>

[Szymon Cofalik]

Fix available on ​branch:t/13449 however I don't think this is the end of the work with this part of the code.

What comes to my mind is providing better test cases and maybe moving some of internal functions to public scope to test them (mergeElements() I am looking at you). I would also look if during whole cutting and merging we really need so many bookmarks (at one moment I had <h1><bookmark><bookmark><bookmark></h1>).

[Szymon Cofalik]

Also, I would like to know why mergeElements() has to use loop to "throw" nodes from one node to another one. Shouldn't be easier just to move all childNodes of one node? I guess there might be some edge cases where this won't result in proper merge, but I can't think of any now.

[Olek Nowodziński]

Merged into major in ​git:e480e6f.