Changes between Initial Version and Version 1 of Ticket #13453, comment 9


Ignore:
Timestamp:
Jun 26, 2015, 10:25:16 AM (9 years ago)
Author:
Szymon Cofalik
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13453, comment 9

    initial v1  
    11My approach was the one suggested by Reinmar.
     2
     3
    241) As he said, this is a different case so we won't include it into range affecting.
     5
     6
    372) Changing `isDropRangeAffectedByDragRange()` would require writing special tests for that function and some cases that are now passing might fail (this was my experience when I started to mess with `isDropRangeAffectedByDragRange()` even though I was pretty sure that my change is actually fixing real-world scenarios)
     8
     9
    4103) Aborting the script is most similiar to what browser do when we drag onto selection.
     11
     12
    5134) @a.delura: we would have to change drop position to either start or end of drag range which would result in same content as when aborting script, but we would additional fire events and create snapshots, which are not needed.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy