Changes between Version 1 and Version 2 of Ticket #13453, comment 9
- Timestamp:
- Jun 26, 2015, 10:26:40 AM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #13453, comment 9
v1 v2 5 5 6 6 7 2) Changing `isDropRangeAffectedByDragRange()` would require writing special tests for that function and some cases that are now passing might fail (this was my experience when I started to mess with `isDropRangeAffectedByDragRange()` even though I was pretty sure that my change is actually fixing real-world scenarios) 7 2) Changing `isDropRangeAffectedByDragRange()` would require writing special tests for that function and some cases that are now passing might fail (this was my experience when I started to mess with `isDropRangeAffectedByDragRange()` even though I was pretty sure that my change is actually fixing real-world scenarios). Things we do with `isDropRangeAffectedByDragRange()` are pretty complicated so it is better to leave the function and the tests alone. 8 8 9 9