Changes between Initial Version and Version 1 of Ticket #13794, comment 5


Ignore:
Timestamp:
Feb 21, 2017, 5:01:11 PM (3 years ago)
Author:
Gosh Snobo
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13794, comment 5

    initial v1  
    1 I would like to reopen this ticket. Currently, {{{onUploaded}}} sets image width & height if non-empty values are returned from server, otherwise it sets {{{$img.naturalWidth}}} & {{{$img.naturalHeight}}}. But I think it should be a valid scenario to NOT set width/height, e.g. to allow for responsive images (those with {{{max-width=100%}}} in the CSS).
     1I would propose to reopen this ticket. Currently, {{{onUploaded}}} sets image width & height if non-empty values are returned from server, otherwise it sets {{{$img.naturalWidth}}} & {{{$img.naturalHeight}}}. But I think it should be a valid scenario to NOT set width/height, e.g. to allow for responsive images (those with {{{max-width=100%}}} in the CSS).
    22
    33In case of traditionally uploaded image, {{{config.image2_prefillDimensions}}} setting serves exactly this purpose. In case of dropped upload, however, this setting has no effect. So imho either the same setting should be also governed by {{{onUploaded}}}, or we need a new setting (though I think it would be more confusing).
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy